use empty string to "unset" variables #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the memento[1] and environment variable collection[2] apis don't support "unsetting" variables, only deleting them from the collection, which leads to those variables being left along. this change uses the empty string instead. posix calls this value "null" for environment variables, and it's technically different from the variable being unset but the closest we can get. [1]: https://code.visualstudio.com/api/references/vscode-api#Memento [2]: https://code.visualstudio.com/api/references/vscode-api#EnvironmentVariableCollection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the memento1 and environment variable collection2 apis
don't support "unsetting" variables,
only deleting them from the collection,
which leads to those variables being left along.
this change uses the empty string instead.
posix calls this value "null" for environment variables,
and it's technically different from the variable being unset
but the closest we can get.